Foreign Keys with cascading deletes #1261
Conversation
There was a problem hiding this comment.
@CodingGorilla changes looks good. Thank you for adding documentation.
I have only two requests for tests:
- to verify if the rollback statement for foreign key will be properly generated
- to verify that if someone changed the cascading configuration then script will be properly generated
We had a lot of bugs related to that with indexes before, so I'd like to be 100% sure that we won't introduce them.
documentation/documentation/documents/configuration/foreign_keys.md
Outdated
Show resolved
Hide resolved
Working on updating the foreign key documentation
…meter in favor of using the configuration function Updating the documentation for cascading deletes and external foreign keys
…ys.md Co-Authored-By: Oskar Dudycz <oskar.dudycz@gmail.com>
… keys and apply the required changes and rollbacks
There was a problem hiding this comment.
@oskardudycz Changes look good to me except for few typos in the unit test method names, left a comment.
|
With regards to failing build, it is due to a random blinking test pertaining to |
|
@mysticmind as discussed, I'll try to tackle that in separate PR, as this blinker is not related to this PR. |
|
@oskardudycz Looks good 👍 Thanks again for finishing this up for me. |
Adding the ability to cascade deletes when creating a foreign key